Upgrade pydata theme #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da1910
requested changes
Jan 31, 2022
Crap. That’s my fault. Was testing something and should have not committed. |
|
@da1910, removed and ready for you to take a look. |
|
Fonts appear off to me, both locally built and looking at the CI artifact. Especially noticeable in the "Attributes" section:
For comparison, the currently deployed version (probably |
Yeah, that disqualifies me 😅 |
|
Closing this until we can figure out styling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest
pydata-sphinx-themehas a new build process and it's a good chance for us to switch over topyproject.toml.Would like someone a bit more familiar than me with NodeJS/web development to take a look at how we can inherit better from the PyData Sphinx Theme as I've effectively just copied the files over and I think there's a better way of doing this.
Resolves #19 and #15.