Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit and spinning of search icon #310

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Oct 9, 2023

make sure you are searching by adding spinner

search.spinner.mp4

@github-actions github-actions bot added documentation maintenance Generic maintenance related labels Oct 9, 2023
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review October 10, 2023 10:24
@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner October 10, 2023 10:24
@germa89
Copy link
Contributor

germa89 commented Oct 10, 2023

Loving it.

Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome to meee!

Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for the gif @Revathyvenugopal162 in the description.

@Revathyvenugopal162 Revathyvenugopal162 merged commit e662e15 into main Oct 11, 2023
@Revathyvenugopal162 Revathyvenugopal162 deleted the maint/dependency-python branch October 11, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Generic maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants