Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default pygment themes friendly (light) and monokai (dark) #341

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

jorgepiloto
Copy link
Member

Fixes #340 by adding default light and dark themes.

I am more than happy to continue the discussion in this thread. It may be possible that UI/UX can raise concerns about these.

What is true is that the contrast is better:

  • Content: white on black (dark) and black on white (light)
  • We can improve docstrings and comments (not very readable): gray on black (dark) light blue on white (light)
Old dark New dark
Screenshot 2024-02-02 at 10-59-50 Getting started — Ansys Sphinx Theme Screenshot 2024-02-02 at 10-55-14 Getting started — Ansys Sphinx Theme
Old light New light
Screenshot 2024-02-02 at 10-59-36 Getting started — Ansys Sphinx Theme Screenshot 2024-02-02 at 10-55-32 Getting started — Ansys Sphinx Theme

@jorgepiloto jorgepiloto requested a review from a team as a code owner February 2, 2024 10:09
@github-actions github-actions bot added the enhancement General improvements to existing features label Feb 2, 2024
@RobPasMue
Copy link
Member

LGTM!

@germa89
Copy link
Contributor

germa89 commented Feb 4, 2024

LGTM!

Same!

Copy link
Contributor

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider using the "friendly" pygments style as the default highlighting style
4 participants