Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add light theme config to css #75

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Jun 14, 2022

Fix #74
Screenshot (19)
Screenshot (20)

@github-actions github-actions bot added the maintenance Generic maintenance related label Jun 14, 2022
@MaxJPRey MaxJPRey requested a review from germa89 June 14, 2022 08:57
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review June 14, 2022 09:07
@RobPasMue
Copy link
Member

Light theme works fine, but would there be a way to set the same "black" color for the logo and theme in dark mode?

@akaszynski
Copy link
Contributor

Light theme works fine, but would there be a way to set the same "black" color for the logo and theme in dark mode?

I think this should be added before merging this PR.

@germa89
Copy link
Contributor

germa89 commented Jun 14, 2022

I wonder if it is better edit the CSS or the logo image.....

@RobPasMue
Copy link
Member

I wonder if it is better edit the CSS or the logo image.....

Totally agree @germa89... I just wanted to say that the colors should be the same, one way or the other 😄

@Revathyvenugopal162
Copy link
Contributor Author

We can change the color. I will update it now. For dark theme giving another logo is also possible.

@RobPasMue
Copy link
Member

RobPasMue commented Jun 14, 2022

We can change the color. I will update it now. For dark theme giving another logo is also possible.

Don't worry about editing the logo. In fact, the logo should stick to the official Ansys colours, Thus, I do agree with @germa89, its better editing the CSS files for the dark theme format. Thanks @Revathyvenugopal162

Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without checking the color values, it looks good to me. Looking forward to see the output online.

@RobPasMue
Copy link
Member

image

Looks awesome @Revathyvenugopal162 ! Thanks for solving the problem

@Revathyvenugopal162 Revathyvenugopal162 merged commit ce0099e into main Jun 14, 2022
@Revathyvenugopal162 Revathyvenugopal162 deleted the maint/dark-light-mode-of-theme branch June 14, 2022 09:51
@germa89 germa89 mentioned this pull request Jun 15, 2022
@germa89
Copy link
Contributor

germa89 commented Jun 17, 2022

I like the output a lot! The dark theme is much colorful though. But I like it that way. Good job @Revathyvenugopal162 !

1 similar comment
@germa89
Copy link
Contributor

germa89 commented Jun 17, 2022

I like the output a lot! The dark theme is much colorful though. But I like it that way. Good job @Revathyvenugopal162 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Generic maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark and light mode coming from pydata-sphinx-theme 0.9.0
4 participants