Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bold to <strong> tags #92

Merged
merged 2 commits into from
Aug 11, 2022
Merged

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Aug 10, 2022

<strong> tags are set to bolder but it was not showing bold. Font-weight: bolder means "One relative font weight heavier than the parent element" (MDN article). So giving strong tag to font_weight : 900 directly. Fix #79
bold
bold-render

@Revathyvenugopal162 Revathyvenugopal162 added the bug Defects or glitches reported by users or developers label Aug 10, 2022
Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @Revathyvenugopal162 !! :)

@MaxJPRey
Copy link
Contributor

MaxJPRey commented Aug 10, 2022

LGTM. Thanks for adding the screenshot!

@Revathyvenugopal162 Revathyvenugopal162 merged commit 9c08d27 into main Aug 11, 2022
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/showing-bold-strings branch August 11, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bold not showing bold
3 participants