chore: Deprecate library #342
Conversation
for more information, see https://pre-commit.ci
github-actions
bot
added
documentation
AlejandroFernandezLuces
changed the title
|
Interesting, why would the unit tests stop working? If the imports have been done properly they should continue to work, even if the warnings are raised. It's a good way to make sure we are deprecating the library properly in fact |
|
I probably should have kept the files with the imports, let me check if I can make it work. |
for more information, see https://pre-commit.ci
…ols-path into maint/deprecation
|
One of the test modules was removed due to a code cleanup when migrating to common tools. |
|
Okay so now we are running the same tests we had at least - thanks @AlejandroFernandezLuces |
for more information, see https://pre-commit.ci
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
…ols-path into maint/deprecation
RobPasMue
left a comment
RobPasMue
left a comment
There was a problem hiding this comment.
Some small comments - LGTM. Let's hold off to actually deprecate it until we have informed the main developers offline and we have their green light
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
|
@AlejandroFernandezLuces - please announce the deprecation in the internal dev-channel and proceed to merge and do a last release. |
As far as I saw, everything is up to date in ansys-tools-common, so we can proceed with the deprecation of the package. Since unit tests won't work anymore, we must remove the rule requiring the tests, but I do not have permissions to do so.