Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs and build pipeline for public release #136

Merged
merged 25 commits into from
Nov 13, 2023
Merged

Update docs and build pipeline for public release #136

merged 25 commits into from
Nov 13, 2023

Conversation

pkrull-ansys
Copy link
Collaborator

closes #134
closes #135

@github-actions github-actions bot added documentation Improvements or additions to documentation maintenance Package and maintenance related labels Oct 25, 2023
RobPasMue
RobPasMue approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkrull-ansys
Copy link
Collaborator Author

@RobPasMue @MaxJPRey I still don't have a CODECOV_TOKEN secret or a pypi.org repo.

PipKat
PipKat reviewed Oct 26, 2023
View reviewed changes
PipKat
PipKat reviewed Oct 26, 2023
View reviewed changes
PipKat
PipKat approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits suggested.

pkrull-ansys and others added 2 commits October 26, 2023 10:38
@pkrull-ansys @PipKat
Update doc/source/getting_started/index.rst
734d3b3 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pkrull-ansys @PipKat
Update doc/source/getting_started/index.rst
af7dc9b 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
pkrull-ansys and others added 12 commits October 26, 2023 10:40
@pkrull-ansys @PipKat
Update doc/source/getting_started/index.rst
fcd9c98 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pkrull-ansys @PipKat
Update doc/source/getting_started/index.rst
436bbbf 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pkrull-ansys @PipKat
Update doc/source/getting_started/index.rst
392fb6e 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pkrull-ansys @PipKat
Update doc/source/getting_started/index.rst
4b4997c 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pkrull-ansys @PipKat
Update pyproject.toml
d86e574 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pkrull-ansys @PipKat
Update src/ansys/additive/core/additive.py
0013033 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pkrull-ansys @PipKat
Update src/ansys/additive/core/additive.py
33a64ec 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pkrull-ansys @PipKat
Update src/ansys/additive/core/additive.py
d0ff5d2 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pkrull-ansys @PipKat
Update src/ansys/additive/core/additive.py
5efc5a3 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@pkrull-ansys
Address review comments
2ffc524
@pkrull-ansys
Merge branch 'maint/135/go-public' of https://github.com/ansys/pyaddi…
8940355 
…tive into maint/135/go-public
@pkrull-ansys
Update vale dictionary
06f5c3d
@RobPasMue
Copy link
Member

@RobPasMue @MaxJPRey I still don't have a CODECOV_TOKEN secret or a pypi.org repo.

@pkrull-ansys the moment you want to go public we will generate it for you. Both things require the repository to be public.

@pkrull-ansys
Copy link
Collaborator Author

pkrull-ansys commented Oct 27, 2023 •
edited
Loading

Related to ansys-internal/oss-approval-tracklist#22 and ansys-internal/oss-approval-tracklist#23

@pkrull-ansys
Copy link
Collaborator Author

@MaxJPRey Any update from legal?

@MaxJPRey
Copy link
Contributor

MaxJPRey commented Nov 4, 2023

@MaxJPRey Any update from legal?

Hi @pkrull-ansys ,
I am supposed to meet with them this week.

@RobPasMue RobPasMue enabled auto-merge November 13, 2023 16:09
@RobPasMue RobPasMue added this pull request to the merge queue Nov 13, 2023
Merged via the queue into main with commit 1693d9e Nov 13, 2023
@RobPasMue RobPasMue deleted the maint/135/go-public branch November 13, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make pyadditive public Readme still assumes the package is internal
4 participants
@pkrull-ansys @RobPasMue @MaxJPRey @PipKat