Allow multiple additive server connections #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
…additive into feat/9/refactor-startup
deleon117
approved these changes
Nov 3, 2023
klmcadams
approved these changes
Nov 3, 2023
| Laser power (W). | ||
| scan_speed: float | ||
| Laser scan speed (m/s). | ||
| characteristic_widt: float |
Collaborator
There was a problem hiding this comment.
Suggested change
| characteristic_widt: float | |
| characteristic_width: float |
|
|
||
| # act, assert | ||
| with pytest.raises(FileNotFoundError) as excinfo: | ||
| LocalServer.launch(TEST_VALID_PORT, tmp_path, "242") |
Collaborator
There was a problem hiding this comment.
Once 242 exists I think you'll have to change the version. Instead, you could choose an old version of Ansys that pyadditive does not support like 212 for example, or a fake version
Comment on lines
+60
to
+67
| with pytest.raises(ValueError): | ||
| check_valid_port(1023) | ||
| with pytest.raises(ValueError): | ||
| check_valid_port(65536) | ||
| with pytest.raises(ValueError): | ||
| check_valid_port("1023") | ||
| with pytest.raises(ValueError): | ||
| check_valid_port("0", 1, 2) |
Collaborator
There was a problem hiding this comment.
Suggested change
| with pytest.raises(ValueError): | |
| check_valid_port(1023) | |
| with pytest.raises(ValueError): | |
| check_valid_port(65536) | |
| with pytest.raises(ValueError): | |
| check_valid_port("1023") | |
| with pytest.raises(ValueError): | |
| check_valid_port("0", 1, 2) | |
| ports = [1024, 65535, "1024"] | |
| for port in ports: | |
| with pytest.raises(ValueError): | |
| check_valid_port(port) | |
| with pytest.raises(ValueError): | |
| check_valid_port("0", 1, 2) |
Comment on lines
+52
to
+55
| check_valid_port(1024) | ||
| check_valid_port(65535) | ||
| check_valid_port("1024") | ||
| check_valid_port("1", 0, 2) |
Collaborator
There was a problem hiding this comment.
Suggested change
| check_valid_port(1024) | |
| check_valid_port(65535) | |
| check_valid_port("1024") | |
| check_valid_port("1", 0, 2) | |
| ports = [1024, 65535, "1024"] | |
| [check_valid_port(port) for port in ports] | |
| check_valid_port("1", 0, 2) |
Comment on lines
+36
to
+39
| check_valid_ip("1.2.3.4") | ||
| check_valid_ip("127.0.0.1") | ||
| check_valid_ip("8.8.8.8") | ||
| check_valid_ip("localhost") |
Collaborator
There was a problem hiding this comment.
Suggested change
| check_valid_ip("1.2.3.4") | |
| check_valid_ip("127.0.0.1") | |
| check_valid_ip("8.8.8.8") | |
| check_valid_ip("localhost") | |
| ips = ["1.2.3.4", "127.0.0.1", "8.8.8.8", "localhost"] | |
| [check_valid_ip(ip) for ip in ips] |
This was referenced Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9
closes #55