Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ansys product version to Additive init #170

Merged
merged 7 commits into from
Nov 21, 2023
Merged

Add Ansys product version to Additive init #170

merged 7 commits into from
Nov 21, 2023

Conversation

pkrull-ansys
Copy link
Collaborator

closes #162

@github-actions github-actions bot added testing enhancement New features or code improvements labels Nov 20, 2023
@github-actions github-actions bot added testing and removed testing labels Nov 20, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (594e625) 97.34% compared to head (89a4247) 97.70%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #170      +/-   ##
==========================================
+ Coverage   97.34%   97.70%   +0.35%     
==========================================
  Files          27       27              
  Lines        2483     2479       -4     
==========================================
+ Hits         2417     2422       +5     
+ Misses         66       57       -9

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added maintenance Package and maintenance related testing and removed testing labels Nov 21, 2023
@pkrull-ansys pkrull-ansys requested a review from PipKat November 21, 2023 06:16
klmcadams
klmcadams approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@klmcadams klmcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just had a few suggestions

PipKat
PipKat approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkrull-ansys Looking good! Probably the most consistent documentation I've seen!

@github-actions github-actions bot added testing and removed testing labels Nov 21, 2023
@pkrull-ansys @PipKat @klmcadams
Apply suggestions from code review
c7daf7c 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Co-authored-by: Kerry McAdams <58492561+klmcadams@users.noreply.github.com>
@github-actions github-actions bot added testing and removed testing labels Nov 21, 2023
@github-actions github-actions bot added testing and removed testing labels Nov 21, 2023
@pkrull-ansys pkrull-ansys merged commit 504539a into main Nov 21, 2023
@pkrull-ansys pkrull-ansys deleted the feat/162/product-version branch November 21, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klmcadams klmcadams klmcadams approved these changes

@PipKat PipKat PipKat approved these changes

Assignees
No one assigned
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Ansys product version to Additive() parameters
3 participants
@pkrull-ansys @klmcadams @PipKat