Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add number of simulations per server #177

Merged
merged 15 commits into from
Nov 29, 2023
Merged

Add number of simulations per server #177

merged 15 commits into from
Nov 29, 2023

Conversation

pkrull-ansys
Copy link
Collaborator

@pkrull-ansys pkrull-ansys commented Nov 28, 2023 •
edited
Loading

closes #172

@github-actions github-actions bot added maintenance Package and maintenance related testing enhancement New features or code improvements labels Nov 28, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 28, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (197d3be) 97.70% compared to head (48ff351) 97.71%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #177      +/-   ##
==========================================
+ Coverage   97.70%   97.71%   +0.01%     
==========================================
  Files          27       27              
  Lines        2479     2490      +11     
==========================================
+ Hits         2422     2433      +11     
  Misses         57       57

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added testing and removed testing labels Nov 28, 2023
klmcadams
klmcadams approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@klmcadams klmcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice examples!

@github-actions github-actions bot added testing and removed testing labels Nov 28, 2023
@github-actions github-actions bot added testing and removed testing labels Nov 28, 2023
@github-actions github-actions bot added testing and removed testing labels Nov 28, 2023
@pkrull-ansys pkrull-ansys mentioned this pull request Nov 28, 2023
Closed
@github-actions github-actions bot added testing and removed testing labels Nov 28, 2023
@github-actions github-actions bot added testing and removed testing labels Nov 28, 2023
@github-actions github-actions bot removed the testing label Nov 28, 2023
PipKat
PipKat approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested some very minor edits.

@pkrull-ansys @PipKat
Apply suggestions from code review
de2fae7 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@github-actions github-actions bot added testing and removed testing labels Nov 28, 2023
@github-actions github-actions bot added testing and removed testing labels Nov 28, 2023
@github-actions github-actions bot added documentation Improvements or additions to documentation testing and removed testing labels Nov 28, 2023
@pkrull-ansys pkrull-ansys added this pull request to the merge queue Nov 29, 2023
Merged via the queue into main with commit 7de9b75 Nov 29, 2023
@pkrull-ansys pkrull-ansys deleted the feat/172/nsims-per-server branch November 29, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julieatansys julieatansys julieatansys left review comments

@PipKat PipKat PipKat approved these changes

@klmcadams klmcadams klmcadams approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add number of simulations per server to Additive init method
4 participants
@pkrull-ansys @julieatansys @klmcadams @PipKat