Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import CSV Usage in PyAdditive/Examples #259

Merged

Conversation

safeerehman
Copy link
Collaborator

Duplicate of #252 with signed commits

  • Update unit tests under tests_*.py to check for nan values when creating a simulation input.
  • Update pyadditive/examples/11_advanced_parametric_study.py to show the usage of import csv file into a study.
  • Update pyproject.toml/doc section

@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Feb 14, 2024
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (12f4140) 97.72% compared to head (d71cdab) 97.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   97.72%   97.72%           
=======================================
  Files          28       28           
  Lines        2767     2770    +3     
=======================================
+ Hits         2704     2707    +3     
  Misses         63       63           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pkrull-ansys pkrull-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one more issue.

@safeerehman safeerehman added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit 0f3bdb1 Feb 15, 2024
32 checks passed
@safeerehman safeerehman deleted the feat/118-import-csv-file-for-parametric-study-example branch February 15, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants