Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: improving documentation of add mesh link #5341

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

anur7
Copy link
Contributor

@anur7 anur7 commented Oct 24, 2024

No description provided.

@anur7 anur7 added the documentation Improvements or additions to documentation label Oct 24, 2024
@anur7 anur7 self-assigned this Oct 24, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@anur7 anur7 linked an issue Oct 24, 2024 that may be closed by this pull request
@anur7 anur7 marked this pull request as ready for review October 24, 2024 18:49
Copy link

@SebastienMorais SebastienMorais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the _unittest/.cov/xml file from the PR

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.25%. Comparing base (14e68c1) to head (12f2878).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5341      +/-   ##
==========================================
- Coverage   84.25%   84.25%   -0.01%     
==========================================
  Files         140      140              
  Lines       58572    58572              
==========================================
- Hits        49351    49350       -1     
- Misses       9221     9222       +1     

@MaxJPRey MaxJPRey changed the title DOC: improving documentation of add mesh link DOCS: improving documentation of add mesh link Oct 25, 2024
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated from another accound, please remove the .cov folder

src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
>>> m3d = Maxwell3d(design="source_design")
>>> m3d.create_setup(name="setup1")
>>> m3d.duplicate_design(name="source_design", save_after_duplicate=True)
>>> m3d.setups[0].add_mesh_link(design="source_design", solution="setup1 : LastAdaptive")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anur7 I'd put here an explanation that the active design in now the duplicated one and you are assigning the mesh link to its setup.
Also please check that self.aedtapp.nominal_adaptive gives the same info in solution. This should give you back "setup1 : LastAdaptive".
Please add the release_desktop at the end.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, @gmalinve self.aedtapp.nominal_adaptive gives you "setup1 : LastAdaptive". Do you want me to subtitute the str with that comand?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anur7 yes, because this is what "solution" needs.

src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
src/ansys/aedt/core/modules/solve_setup.py Outdated Show resolved Hide resolved
@gmalinve
Copy link
Contributor

@anur7 please update the branch and reply to the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improving docstring of add_mesh_link method
4 participants