-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS: improving documentation of add mesh link #5341
base: main
Are you sure you want to change the base?
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the _unittest/.cov/xml file from the PR
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5341 +/- ##
==========================================
- Coverage 84.25% 84.25% -0.01%
==========================================
Files 140 140
Lines 58572 58572
==========================================
- Hits 49351 49350 -1
- Misses 9221 9222 +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As stated from another accound, please remove the .cov
folder
>>> m3d = Maxwell3d(design="source_design") | ||
>>> m3d.create_setup(name="setup1") | ||
>>> m3d.duplicate_design(name="source_design", save_after_duplicate=True) | ||
>>> m3d.setups[0].add_mesh_link(design="source_design", solution="setup1 : LastAdaptive") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anur7 I'd put here an explanation that the active design in now the duplicated one and you are assigning the mesh link to its setup.
Also please check that self.aedtapp.nominal_adaptive gives the same info in solution. This should give you back "setup1 : LastAdaptive".
Please add the release_desktop at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, @gmalinve self.aedtapp.nominal_adaptive gives you "setup1 : LastAdaptive". Do you want me to subtitute the str with that comand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anur7 yes, because this is what "solution" needs.
@anur7 please update the branch and reply to the discussion. |
No description provided.