Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: enable harmonic force #5440

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

FEAT: enable harmonic force #5440

wants to merge 25 commits into from

Conversation

anur7
Copy link
Contributor

@anur7 anur7 commented Nov 18, 2024

With this new PR:

  • Added missing arguments for Transient solver (already done by @JuliusSaitz with the old not merged PR FEAT: Enable harmonic force #4848)
  • Implemented the method for Eddy Current solver.
  • Still not complete, for Transient solver it is needed other improvements.

@anur7 anur7 added the enhancement New features or code improvements label Nov 18, 2024
@anur7 anur7 self-assigned this Nov 18, 2024
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@anur7 anur7 linked an issue Nov 18, 2024 that may be closed by this pull request
2 tasks
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 79.71%. Comparing base (4f47c08) to head (c1364de).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5440      +/-   ##
==========================================
- Coverage   81.37%   79.71%   -1.66%     
==========================================
  Files         151      151              
  Lines       60751    60769      +18     
==========================================
- Hits        49435    48441     -994     
- Misses      11316    12328    +1012     

@anur7 anur7 marked this pull request as ready for review December 12, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

m2d.enable_harmonic_force does not have a complete set of inputs
1 participant