-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: generic empty initial library #5464
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5464 +/- ##
=======================================
Coverage 84.75% 84.75%
=======================================
Files 144 144
Lines 60198 60198
=======================================
Hits 51019 51019
Misses 9179 9179 |
@gkorompi If the user just call create_component(), will it work? I am just wondering if component_library is needed for the default case. |
@Samuelopez-ansys Yes i tested it and it works. For an empty component_library ="" it searches in all libraries, hence it looks like a better default choice. (Nevertheless the user has to give the component_name argument) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.