Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: generic empty initial library #5464

Merged
merged 8 commits into from
Dec 9, 2024
Merged

Conversation

gkorompi
Copy link
Contributor

No description provided.

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gkorompi gkorompi linked an issue Nov 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.75%. Comparing base (30f8c9e) to head (69ab4aa).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5464   +/-   ##
=======================================
  Coverage   84.75%   84.75%           
=======================================
  Files         144      144           
  Lines       60198    60198           
=======================================
  Hits        51019    51019           
  Misses       9179     9179           

@Samuelopez-ansys
Copy link
Member

@gkorompi If the user just call create_component(), will it work? I am just wondering if component_library is needed for the default case.

@gkorompi
Copy link
Contributor Author

gkorompi commented Nov 21, 2024

@gkorompi If the user just call create_component(), will it work? I am just wondering if component_library is needed for the default case.

@Samuelopez-ansys Yes i tested it and it works. For an empty component_library ="" it searches in all libraries, hence it looks like a better default choice. (Nevertheless the user has to give the component_name argument)

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samuelopez-ansys Samuelopez-ansys merged commit c86f8ef into main Dec 9, 2024
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the create_comp_enhancement branch December 9, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve create_component on circuit
2 participants