-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Rescale property in model units #5542
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5542 +/- ##
=======================================
Coverage 84.74% 84.74%
=======================================
Files 144 144
Lines 60198 60199 +1
=======================================
+ Hits 51015 51018 +3
+ Misses 9183 9181 -2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test using this new attribute ?
I have added a test, but this should be tested in the tool itself :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding that test !
Description
Model_units property allows you to get or set the model units. When setting the model units, you can specify whether to rescale the model by adjusting the
rescale_model
attribute.Issue linked
Close #5541
Close #5533
Checklist