Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Rescale property in model units #5542

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Dec 9, 2024

Description

Model_units property allows you to get or set the model units. When setting the model units, you can specify whether to rescale the model by adjusting the rescale_model attribute.

Issue linked

Close #5541
Close #5533

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@Samuelopez-ansys Samuelopez-ansys changed the title Feat/issue 5541 FEAT: Rescale property in model units Dec 9, 2024
@github-actions github-actions bot added the enhancement New features or code improvements label Dec 9, 2024
@Samuelopez-ansys Samuelopez-ansys linked an issue Dec 9, 2024 that may be closed by this pull request
@Samuelopez-ansys Samuelopez-ansys added this to the v0.12.0 milestone Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.74%. Comparing base (c86f8ef) to head (ee01f51).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5542   +/-   ##
=======================================
  Coverage   84.74%   84.74%           
=======================================
  Files         144      144           
  Lines       60198    60199    +1     
=======================================
+ Hits        51015    51018    +3     
+ Misses       9183     9181    -2     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test using this new attribute ?

@Samuelopez-ansys
Copy link
Member Author

I have added a test, but this should be tested in the tool itself :)

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) December 9, 2024 10:06
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding that test !

@Samuelopez-ansys Samuelopez-ansys merged commit 4e678aa into main Dec 9, 2024
43 checks passed
@Samuelopez-ansys Samuelopez-ansys deleted the feat/issue_5541 branch December 9, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow Rescale when model units change Allow rescale when modeler units change
2 participants