Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Improve create_report #5546

Merged
merged 1 commit into from
Dec 9, 2024
Merged

FIX: Improve create_report #5546

merged 1 commit into from
Dec 9, 2024

Conversation

maxcapodi78
Copy link
Collaborator

create_report now automatically get the first Sphere if no argument is passes and set Theta and Phi to All in case they are not defined as variaton dictionary.
plot_field is automatically skipping PML objects.

Description

create_report now automatically get the first Sphere if no argument is passes and set Theta and Phi to All in case they are not defined as variaton dictionary.
plot_field is automatically skipping PML objects.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

…s passes and set Theta and Phi to All in case they are not defined as variaton dictionary.
@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.74%. Comparing base (c86f8ef) to head (4245caa).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5546      +/-   ##
==========================================
- Coverage   84.74%   84.74%   -0.01%     
==========================================
  Files         144      144              
  Lines       60198    60203       +5     
==========================================
+ Hits        51015    51018       +3     
- Misses       9183     9185       +2     

Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxcapodi78 maxcapodi78 enabled auto-merge (squash) December 9, 2024 11:15
@maxcapodi78 maxcapodi78 merged commit 2b04f51 into main Dec 9, 2024
41 of 42 checks passed
@maxcapodi78 maxcapodi78 deleted the Improve_create_report branch December 9, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants