Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR: refactoring of analysis.py #5846

Open
wants to merge 39 commits into
base: main
Choose a base branch
from
Open

Conversation

gmalinve
Copy link
Contributor

@gmalinve gmalinve commented Feb 27, 2025

Description

See linked issue

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@gmalinve gmalinve linked an issue Feb 27, 2025 that may be closed by this pull request
@github-actions github-actions bot added the enhancement New features or code improvements label Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

Attention: Patch coverage is 73.86364% with 23 lines in your changes missing coverage. Please review.

Project coverage is 81.21%. Comparing base (74863ab) to head (750cf24).

❌ Your patch check has failed because the patch coverage (73.86%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5846      +/-   ##
==========================================
- Coverage   84.92%   81.21%   -3.71%     
==========================================
  Files         161      161              
  Lines       62107    62137      +30     
==========================================
- Hits        52745    50466    -2279     
- Misses       9362    11671    +2309     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gmalinve gmalinve marked this pull request as ready for review February 27, 2025 10:55
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@Samuelopez-ansys Samuelopez-ansys enabled auto-merge (squash) February 28, 2025 14:24
@gmalinve gmalinve linked an issue Mar 3, 2025 that may be closed by this pull request
@gmalinve gmalinve requested a review from jvela018 March 3, 2025 10:09
jvela018
jvela018 previously approved these changes Mar 3, 2025
Copy link
Contributor

@jvela018 jvela018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmalinve gmalinve linked an issue Mar 5, 2025 that may be closed by this pull request
2 tasks
@Samuelopez-ansys Samuelopez-ansys mentioned this pull request Mar 5, 2025
7 tasks
@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug located in Quantity class Add pressure in constants.py Refactoring analysis.py
4 participants