Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize project layout #115

Merged
merged 6 commits into from
Jun 14, 2022
Merged

Modernize project layout #115

merged 6 commits into from
Jun 14, 2022

Conversation

jorgepiloto
Copy link
Member

This PR introduces the following changes:

  • Remove base directory automation shell and batch scripts.
  • Start using tox.ini for automation.
  • Update CI/CD workflows to new tox.ini.

Sorry, something went wrong.

@jorgepiloto
Copy link
Member Author

This PR is related to ansys/ansys-templates#92.

Notice this is not a Python project but still takes advantage of pre-commit andtox.ini for automation.

Vale will be implemented in a separate PR. I expect lots of warnings comming from this tool as this project has lots of doc content.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@jorgepiloto jorgepiloto force-pushed the maint/pkg branch 4 times, most recently from 4d24659 to 8e56c56 Compare June 14, 2022 10:38

Unverified

This user has not yet uploaded their public signing key.

Unverified

This user has not yet uploaded their public signing key.
@jorgepiloto jorgepiloto marked this pull request as ready for review June 14, 2022 12:53
@jorgepiloto jorgepiloto requested review from germa89 and RobPasMue June 14, 2022 12:53

Unverified

This user has not yet uploaded their public signing key.
@jorgepiloto
Copy link
Member Author

Not sure where these "docs_build" and "pre-commit checks" are comming from...

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! =)

@RobPasMue
Copy link
Member

Not sure where these "docs_build" and "pre-commit checks" are comming from...

It was coming from a branch rule mainly, once you changed the step names, the rules didn't update automatically. I just updated it. No worries anymore.

@jorgepiloto
Copy link
Member Author

I remember protection rules for main branch were discussed some time ago. From private discussion, this is something we need to enable in the settings section.

As @RobPasMue, this condition should be spread to other projects in the ecosystem.

I'll take a look to https://github.com/jcwilson/git-hooks/blob/master/included/pre-commit-protect-branch.

We may also have the possibility to implement branches protection locally.

@jorgepiloto jorgepiloto merged commit 4faf464 into main Jun 14, 2022
@jorgepiloto jorgepiloto deleted the maint/pkg branch June 14, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants