-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize project layout #115
Conversation
This PR is related to ansys/ansys-templates#92. Notice this is not a Python project but still takes advantage of Vale will be implemented in a separate PR. I expect lots of warnings comming from this tool as this project has lots of doc content. |
4d24659
to
8e56c56
Compare
Not sure where these "docs_build" and "pre-commit checks" are comming from... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! =)
It was coming from a branch rule mainly, once you changed the step names, the rules didn't update automatically. I just updated it. No worries anymore. |
I remember protection rules for main branch were discussed some time ago. From private discussion, this is something we need to enable in the settings section. As @RobPasMue, this condition should be spread to other projects in the ecosystem. I'll take a look to https://github.com/jcwilson/git-hooks/blob/master/included/pre-commit-protect-branch. We may also have the possibility to implement branches protection locally. |
This PR introduces the following changes:
tox.ini
for automation.tox.ini
.