Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update packaging guide #44

Merged
merged 3 commits into from
Mar 21, 2022

Conversation

greschd
Copy link
Member

@greschd greschd commented Feb 9, 2022

Remove guide regarding setup.py, and recommend flit with pyproject.toml instead. For applications (which should have pinned versions instead of loose ones), recommend poetry.

@greschd
Copy link
Member Author

greschd commented Feb 9, 2022

@akaszynski I noticed e.g. in "Development Practices" there are some places referring to

pip install -r requirements_test.txt

Since the template now uses optional requirements for this it might be better to change to pip install -e .[test]. However, in general this depends on how exactly the repository being worked on is structured.

akaszynski
akaszynski previously approved these changes Feb 9, 2022
Copy link
Contributor

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the changes and appreciate the discussion of the merits of filt vs poetry.

@greschd greschd marked this pull request as draft February 17, 2022 08:22
@akaszynski
Copy link
Contributor

@greschd, let's modify this to reflect our choice in poetry.

@greschd greschd changed the title Update packaging guide to refer to 'flit' Update packaging guide to refer to 'poetry' Feb 22, 2022
@greschd greschd marked this pull request as ready for review February 22, 2022 16:24
MaxJPRey
MaxJPRey previously approved these changes Feb 23, 2022
@MaxJPRey
Copy link
Contributor

LGTM.

@akaszynski akaszynski dismissed stale reviews from MaxJPRey and themself February 25, 2022 08:01

outdated

@akaszynski
Copy link
Contributor

Pinging @jorgepiloto to update this based on ansys/ansys-templates#2

@jorgepiloto jorgepiloto force-pushed the maint/update_packaging_to_flit branch 6 times, most recently from 82215aa to 2969efd Compare March 8, 2022 09:20
@jorgepiloto jorgepiloto force-pushed the maint/update_packaging_to_flit branch from 16af98a to fff0808 Compare March 8, 2022 20:32
@jorgepiloto jorgepiloto force-pushed the maint/update_packaging_to_flit branch from 9fbb90e to 38a1ae9 Compare March 21, 2022 08:47
@jorgepiloto jorgepiloto changed the title Update packaging guide to refer to 'poetry' Update packaging guide Mar 21, 2022
@jorgepiloto jorgepiloto mentioned this pull request Mar 21, 2022
3 tasks
@akaszynski
Copy link
Contributor

Thanks for your work @greschd!

@akaszynski akaszynski merged commit d99cad9 into ansys:main Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants