Skip to content

Conversation

@AlejandroFernandezLuces
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces commented Apr 19, 2024

Description

Partially addresses issues from #1110

Issue linked

#1110

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@github-actions github-actions bot added the bug Something isn't working label Apr 19, 2024
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review April 19, 2024 12:09
@AlejandroFernandezLuces AlejandroFernandezLuces requested a review from a team as a code owner April 19, 2024 12:09
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Some minor comments

@RobPasMue RobPasMue linked an issue Apr 19, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobPasMue RobPasMue enabled auto-merge (squash) April 19, 2024 13:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 42.42424% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 90.56%. Comparing base (fb35396) to head (b4cb66b).

Files Patch % Lines
src/ansys/geometry/core/plotting/trame_gui.py 29.62% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
- Coverage   90.76%   90.56%   -0.21%     
==========================================
  Files          93       93              
  Lines        6966     6987      +21     
==========================================
+ Hits         6323     6328       +5     
- Misses        643      659      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue RobPasMue merged commit feb5af6 into main Apr 19, 2024
@RobPasMue RobPasMue deleted the fix/trame-issues branch April 19, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PLOTTING: Trame remote visualization support

5 participants