-
Notifications
You must be signed in to change notification settings - Fork 22
fix: Trame issues #1148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Trame issues #1148
Conversation
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Some minor comments
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
…eometry into fix/trame-issues
RobPasMue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @AlejandroFernandezLuces
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
- Coverage 90.76% 90.56% -0.21%
==========================================
Files 93 93
Lines 6966 6987 +21
==========================================
+ Hits 6323 6328 +5
- Misses 643 659 +16 ☔ View full report in Codecov by Sentry. |
Description
Partially addresses issues from #1110
Issue linked
#1110
Checklist
feat: extrude circle to cylinder)