Skip to content

Conversation

@RobPasMue
Copy link
Member

Description

Demonstrating the usage of PyAnsys Geometry to create a NACA airfoil.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Apr 25, 2024
@RobPasMue RobPasMue requested review from a team and PipKat as code owners April 25, 2024 11:19
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 25, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Apr 25, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Apr 25, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.56%. Comparing base (a9d4779) to head (2845980).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1167   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files          93       93           
  Lines        6987     6987           
=======================================
  Hits         6328     6328           
  Misses        659      659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RobPasMue
Copy link
Member Author

@PipKat - would you mind reviewing it with your infinite wisdom? 🙏🏼

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Apr 25, 2024
PipKat
PipKat previously approved these changes Apr 25, 2024
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes to follow the Google style guide. Use present tense, active voice, and second person (you). Otherwise, it looks great! NOTE: If you don't like "This code ..." as the subject, you can change it to "You ..." instead.

@RobPasMue
Copy link
Member Author

All changes to follow the Google style guide. Use present tense, active voice, and second person (you). Otherwise, it looks great! NOTE: If you don't like "This code ..." as the subject, you can change it to "You ..." instead.

Thanks a lot @PipKat - I really appreciate your time and efforts to make me a better writer... though I sometimes have the feeling I don't learn as fast as I should 😄 invaluable work here from your side!

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels Apr 25, 2024
@RobPasMue RobPasMue merged commit ef147fe into main Apr 25, 2024
@RobPasMue RobPasMue deleted the docs/naca-airfoil-example branch April 25, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants