Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove server_logs_folder argument for Discovery and SpaceClaim #1387

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

RobPasMue
Copy link
Member

Description

After conversations with @b-matteo - environment variable ANS_DSCO_REMOTE_LOGS_FOLDER is only applicable for the Geometry Service. Removing it as a potential input for SpaceClaim and Discovery

Issue linked

None - but related to #1377

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Aug 30, 2024
@RobPasMue RobPasMue requested a review from a team as a code owner August 30, 2024 07:46
@github-actions github-actions bot added the bug Something isn't working label Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.77%. Comparing base (9a93725) to head (94ef5e3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/geometry/core/connection/launcher.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1387      +/-   ##
==========================================
- Coverage   91.79%   91.77%   -0.03%     
==========================================
  Files          86       86              
  Lines        6802     6806       +4     
==========================================
+ Hits         6244     6246       +2     
- Misses        558      560       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@RobPasMue RobPasMue merged commit 719d21d into main Sep 2, 2024
43 checks passed
@RobPasMue RobPasMue deleted the fix/remove-server-logs-folder-from-scdm-and-disco branch September 2, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants