Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: translating sketch issues when using a custom default unit #1808

Merged
merged 7 commits into from
Mar 10, 2025

Conversation

RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Mar 10, 2025

Description

Translation of sketches wasn't being handled properly. Now it should be consistent.

Issue linked

Closes #1807

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Mar 10, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner March 10, 2025 17:13
@github-actions github-actions bot added the bug Something isn't working label Mar 10, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 10, 2025
@RobPasMue RobPasMue force-pushed the fix/translate-sketch-issue branch from c46c621 to 7af953d Compare March 10, 2025 17:22
@github-actions github-actions bot removed the maintenance Package and maintenance related label Mar 10, 2025
@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 10, 2025
@RobPasMue RobPasMue requested a review from PipKat as a code owner March 10, 2025 19:10
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 10, 2025
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Mar 10, 2025
Copy link
Contributor

@b-matteo b-matteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RobPasMue RobPasMue enabled auto-merge (squash) March 10, 2025 19:47
@RobPasMue RobPasMue merged commit 7039876 into blitz Mar 10, 2025
25 of 29 checks passed
@RobPasMue RobPasMue deleted the fix/translate-sketch-issue branch March 10, 2025 20:13
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.62%. Comparing base (b827101) to head (9b7ff61).
Report is 1 commits behind head on blitz.

Additional details and impacted files
@@            Coverage Diff             @@
##            blitz    #1808      +/-   ##
==========================================
+ Coverage   90.60%   90.62%   +0.01%     
==========================================
  Files          92       92              
  Lines        8474     8476       +2     
==========================================
+ Hits         7678     7681       +3     
+ Misses        796      795       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue calling translate_sketch_plane_by_distance when default units is not meters
3 participants