Skip to content

Conversation

@smereu
Copy link
Contributor

@smereu smereu commented Jul 7, 2025

Description

This PR updates the test for file insert to take into account changes made in the SpaceClaim code in PR https://tfs.ansys.com:8443/tfs/ANSYS_Development/SpaceClaim/_git/SpaceClaim/pullrequest/604000

Issue linked

#1795

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@smereu smereu self-assigned this Jul 7, 2025
@smereu smereu requested a review from a team as a code owner July 7, 2025 21:22
@github-actions github-actions bot added the bug Something isn't working label Jul 7, 2025
@smereu
Copy link
Contributor Author

smereu commented Jul 7, 2025

@RobPasMue The problem with insert geometry was more complex than initially realized, It required another change in the CoreService. When the core service change corresponding to https://tfs.ansys.com:8443/tfs/ANSYS_Development/SpaceClaim/_git/SpaceClaim/pullrequest/604000 makes into the central testing, the insert test will start failing and this PR should be merged to fix it (a component name has changed as secondary effect of the fix)

@RobPasMue
Copy link
Member

@RobPasMue The problem with insert geometry was more complex than initially realized, It required another change in the CoreService. When the core service change corresponding to https://tfs.ansys.com:8443/tfs/ANSYS_Development/SpaceClaim/_git/SpaceClaim/pullrequest/604000 makes into the central testing, the insert test will start failing and this PR should be merged to fix it (a component name has changed as secondary effect of the fix)

Awesome, thanks for the update @smereu -- I'll keep an eye out!

@github-actions github-actions bot added the testing Anything related to tests label Jul 9, 2025
@RobPasMue RobPasMue merged commit 5196f26 into main Jul 9, 2025
20 of 25 checks passed
@RobPasMue RobPasMue deleted the fix/internalize_document_after_insert_update_test branch July 9, 2025 14:53
@RobPasMue RobPasMue linked an issue Jul 14, 2025 that may be closed by this pull request
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After calling design.insert_file, design instance gets corrupted

5 participants