-
Notifications
You must be signed in to change notification settings - Fork 21
feat: option to write body facets on save #2169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonahrb We need to skip these tests for older version and we might need a minimum version right?
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2169 +/- ##
==========================================
- Coverage 94.72% 94.71% -0.02%
==========================================
Files 141 141
Lines 10319 10323 +4
==========================================
+ Hits 9775 9777 +2
- Misses 544 546 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM!
Description
Write body facets into the scdocx on save
Issue linked
Checklist
feat: extrude circle to cylinder
)