Skip to content

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Aug 12, 2025

Description

Write body facets into the scdocx on save

Issue linked

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb requested a review from a team as a code owner August 12, 2025 16:10
@jonahrb jonahrb self-assigned this Aug 12, 2025
@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Aug 12, 2025
Copy link
Contributor

@RyanJWard RyanJWard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@RyanJWard RyanJWard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonahrb We need to skip these tests for older version and we might need a minimum version right?

@github-actions github-actions bot added the testing Anything related to tests label Aug 12, 2025
Copy link

codecov bot commented Aug 12, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.71%. Comparing base (725e55e) to head (fb12afc).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ys/geometry/core/_grpc/_services/v0/conversions.py 50.00% 2 Missing ⚠️
src/ansys/geometry/core/designer/design.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2169      +/-   ##
==========================================
- Coverage   94.72%   94.71%   -0.02%     
==========================================
  Files         141      141              
  Lines       10319    10323       +4     
==========================================
+ Hits         9775     9777       +2     
- Misses        544      546       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonahrb jonahrb requested a review from RyanJWard August 13, 2025 13:51
@github-actions github-actions bot removed the maintenance Package and maintenance related label Aug 13, 2025
@jonahrb jonahrb requested a review from RobPasMue August 13, 2025 14:03
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM!

@jonahrb jonahrb merged commit 05dbe8e into main Aug 13, 2025
50 of 51 checks passed
@jonahrb jonahrb deleted the feat/write-body-facets branch August 13, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants