Skip to content

Conversation

@RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Sep 24, 2025

Description

for 252 we need to check for a match, not in

Issue linked

252 will try to launch the wrong executable

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard self-assigned this Sep 24, 2025
@RyanJWard RyanJWard requested a review from a team as a code owner September 24, 2025 17:26
@github-actions github-actions bot added the enhancement New features or code improvements label Sep 24, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Sep 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.61%. Comparing base (57587fa) to head (344affe).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2255      +/-   ##
==========================================
- Coverage   94.69%   94.61%   -0.09%     
==========================================
  Files         142      142              
  Lines       10615    10615              
==========================================
- Hits        10052    10043       -9     
- Misses        563      572       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RyanJWard RyanJWard enabled auto-merge (squash) September 24, 2025 19:56
@RobPasMue RobPasMue disabled auto-merge September 25, 2025 07:40
@RobPasMue RobPasMue merged commit 35a009b into main Sep 25, 2025
58 of 84 checks passed
@RobPasMue RobPasMue deleted the feat/update_linux_launcher_code branch September 25, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants