Skip to content

Conversation

@RobPasMue
Copy link
Member

@RobPasMue RobPasMue commented Oct 31, 2025

Description

Following #2349 - we should properly expose the server working directory as follows (to all backends launched locally). Also, the default should always be the current working directory of the parent process IMO to provide consistency. But we should allow users to modify it if they want to.

Issue linked

None

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Oct 31, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner October 31, 2025 08:52
@RobPasMue RobPasMue requested a review from RyanJWard October 31, 2025 08:52
@github-actions github-actions bot added the enhancement New features or code improvements label Oct 31, 2025
@codecov
Copy link

codecov bot commented Oct 31, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.36%. Comparing base (8a01771) to head (8355e67).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ansys/geometry/core/connection/product_instance.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2350      +/-   ##
==========================================
+ Coverage   95.34%   95.36%   +0.01%     
==========================================
  Files         168      168              
  Lines       11103    11101       -2     
==========================================
  Hits        10586    10586              
+ Misses        517      515       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MaxJPRey
Copy link
Contributor

LGTM.

Copy link
Contributor

@RyanJWard RyanJWard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@RobPasMue RobPasMue merged commit b5592a9 into main Oct 31, 2025
48 of 50 checks passed
@RobPasMue RobPasMue deleted the feat/expose-proper-server-working-dir branch October 31, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants