fix: change find split edges default #2361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2361 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 168 168
Lines 11101 11105 +4
=======================================
+ Hits 10586 10590 +4
Misses 515 515 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jonahrb
approved these changes
Nov 10, 2025
RobPasMue
reviewed
Nov 11, 2025
Comment on lines
+80
to
+81
| print("distance:", request.distance) | ||
| print("angle:", request.angle) |
Member
There was a problem hiding this comment.
@jacobrkerstetter - these prints have to be removed.
RobPasMue
reviewed
Nov 11, 2025
Comment on lines
+139
to
+140
| print("angle:", angle) | ||
| print("length:", length) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change default split edges value to None and test None and 0 inputs
Issue linked
related to TFS Bug 1346069
Checklist
feat: extrude circle to cylinder)