Skip to content

fix: Broken edge picking #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 4, 2024
Merged

fix: Broken edge picking #905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c10860
fix: Broken edge picking
AlejandroFernandezLuces Jan 3, 2024
bbaf2e7
Add missing objects with edges
AlejandroFernandezLuces Jan 4, 2024
f01a8e2
fix bug in design point
AlejandroFernandezLuces Jan 4, 2024
84de789
Merge branch 'main' into fix/broken-edge-picking
RobPasMue Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/ansys/geometry/core/plotting/plotter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,8 @@ def add_design_point(self, design_point: DesignPoint, **plotting_options) -> Non
actor = self.scene.add_mesh(design_point._to_polydata(), **plotting_options)

# save the actor to the object/actor map
design_point = GeomObjectPlot(actor=actor, object=design_point, add_body_edges=False)

self._geom_object_actors_map[actor] = design_point

def add(
Expand Down
11 changes: 8 additions & 3 deletions src/ansys/geometry/core/plotting/plotter_helper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
ViewButton,
ViewDirection,
)
from ansys.geometry.core.sketch.face import SketchFace
from ansys.geometry.core.sketch.sketch import Sketch


class PlotterHelper:
Expand Down Expand Up @@ -229,10 +231,13 @@ def compute_edge_object_map(self) -> Dict[pv.Actor, EdgePlot]:
"""
for object in self._geom_object_actors_map.values():
# get edges only from bodies
geom_obj = object.object
if (
isinstance(object, Body)
or isinstance(object, MasterBody)
or isinstance(object, Face)
isinstance(geom_obj, Body)
or isinstance(geom_obj, MasterBody)
or isinstance(geom_obj, Face)
or isinstance(geom_obj, SketchFace)
or isinstance(geom_obj, Sketch)
):
for edge in object.edges:
self._edge_actors_map[edge.actor] = edge
Expand Down