Skip to content

Conversation

@clatapie
Copy link
Collaborator

@clatapie clatapie commented Jun 7, 2023

Closes #114.

@clatapie clatapie requested a review from germa89 June 7, 2023 10:36
@clatapie clatapie self-assigned this Jun 7, 2023
@clatapie clatapie linked an issue Jun 7, 2023 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the bug Something isn't working label Jun 7, 2023
@clatapie clatapie requested a review from RobPasMue June 7, 2023 10:56
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

Codecov Report

Merging #115 (65e3fcc) into main (68aeee7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   92.70%   92.71%   +0.01%     
==========================================
  Files           2        2              
  Lines         548      549       +1     
==========================================
+ Hits          508      509       +1     
  Misses         40       40              

@clatapie
Copy link
Collaborator Author

clatapie commented Jun 7, 2023

Issues in doc-build, fixing it with https://github.com/ansys/pymapdl/pull/2083/files.

@clatapie clatapie enabled auto-merge (squash) June 7, 2023 12:34
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@clatapie clatapie disabled auto-merge June 8, 2023 07:44
@clatapie
Copy link
Collaborator Author

clatapie commented Jun 8, 2023

The unit tests are now fixed but the documentation building is failing.

@clatapie
Copy link
Collaborator Author

clatapie commented Jun 8, 2023

An error is raised when adding the updated links in the intersphinx_mapping.

@clatapie clatapie requested a review from germa89 June 8, 2023 15:17
@clatapie
Copy link
Collaborator Author

clatapie commented Jun 8, 2023

I added new unit tests for the comment you posted @germa89, it should run fine now

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@germa89
Copy link
Collaborator

germa89 commented Jun 8, 2023

By the way, why there is not code coverage checks??

@clatapie
Copy link
Collaborator Author

clatapie commented Jun 8, 2023

By the way, why there is not code coverage checks??

Good question, I will add it in the checks

@clatapie clatapie enabled auto-merge (squash) June 9, 2023 08:19
@clatapie clatapie merged commit 4b9f310 into main Jun 9, 2023
@clatapie clatapie deleted the fix/vec_mat_def branch June 9, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug located in vec and mat functions

4 participants