-
Notifications
You must be signed in to change notification settings - Fork 5
Fixing mat and vec functions
#115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
==========================================
+ Coverage 92.70% 92.71% +0.01%
==========================================
Files 2 2
Lines 548 549 +1
==========================================
+ Hits 508 509 +1
Misses 40 40 |
|
Issues in doc-build, fixing it with https://github.com/ansys/pymapdl/pull/2083/files. |
germa89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
The unit tests are now fixed but the documentation building is failing. |
|
An error is raised when adding the updated links in the |
|
I added new unit tests for the comment you posted @germa89, it should run fine now |
germa89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
germa89
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
By the way, why there is not code coverage checks?? |
Good question, I will add it in the checks |
Closes #114.