Skip to content

Adding the examples to the Cache #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jan 16, 2023
Merged

Adding the examples to the Cache #18

merged 20 commits into from
Jan 16, 2023

Conversation

@clatapie
Copy link
Collaborator

@clatapie clatapie commented Jan 12, 2023

Closes #17.

@clatapie clatapie requested a review from RobPasMue January 12, 2023 11:11
@clatapie clatapie self-assigned this Jan 12, 2023
@clatapie clatapie linked an issue Jan 12, 2023 that may be closed by this pull request
Add the examples to the Cache #17
Closed
@github-actions github-actions bot added maintenance Package and maintenance related CI/CD labels Jan 12, 2023
RobPasMue
RobPasMue reviewed Jan 12, 2023
View reviewed changes
RobPasMue
RobPasMue reviewed Jan 12, 2023
View reviewed changes
@clatapie clatapie marked this pull request as draft January 12, 2023 11:49
@clatapie clatapie marked this pull request as draft January 12, 2023 11:49
@clatapie clatapie marked this pull request as draft January 12, 2023 11:49
@clatapie clatapie marked this pull request as ready for review January 13, 2023 17:06
@clatapie clatapie requested a review from germa89 January 13, 2023 17:06
@clatapie
Copy link
Collaborator Author

clatapie commented Jan 13, 2023

The cache examples is very light because there are only a few examples in this repository.
I was looking for an error on that step but it seems that it is running the right way. I checked it with the debug logging.

@RobPasMue
Copy link
Member

RobPasMue commented Jan 16, 2023

The cache examples is very light because there are only a few examples in this repository. I was looking for an error on that step but it seems that it is running the right way. I checked it with the debug logging.

Well, if it's just light, then that's it. I'll try to have it a look this morning. Thanks @clatapie!

@RobPasMue RobPasMue self-requested a review January 16, 2023 06:42
RobPasMue
RobPasMue reviewed Jan 16, 2023
View reviewed changes
RobPasMue
RobPasMue approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the cache is working :)

@RobPasMue
Copy link
Member

RobPasMue commented Jan 16, 2023

I can confirm the cache is working. Execution time of examples is 0.00 seconds when cache is restored. Great job @clatapie

@clatapie @RobPasMue
Apply suggestions from code review
57b4104 
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
germa89
germa89 approved these changes Jan 16, 2023
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clatapie clatapie merged commit 411fec1 into main Jan 16, 2023
@clatapie clatapie deleted the maint/examples_to_cache branch January 16, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@germa89 germa89 germa89 approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

Assignees

@clatapie clatapie

Labels

maintenance Package and maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the examples to the Cache

4 participants

@clatapie @RobPasMue @germa89