Skip to content

Conversation

@clatapie
Copy link
Collaborator

Closes #19.

@clatapie clatapie self-assigned this Jan 16, 2023
@clatapie clatapie linked an issue Jan 16, 2023 that may be closed by this pull request
@github-actions github-actions bot added maintenance Package and maintenance related CI/CD labels Jan 16, 2023
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pyproject.toml file also has a reference to the ignore_words.txt file. Please update this reference too. Once done, this is ready to be merged.

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for bringing this up @jorgepiloto, great idea!

clatapie and others added 2 commits January 17, 2023 09:58
Co-authored-by: Roberto Pastor Muela <roberto.pastormuela@ansys.com>
@RobPasMue
Copy link
Member

The pyproject.toml file also has a reference to the ignore_words.txt file. Please update this reference too. Once done, this is ready to be merged.

I think it's only for config purposes:

ignore-words = "doc/styles/Vocab/ANSYS/accept.txt"

As it is, it is fine =)

@RobPasMue RobPasMue merged commit 03c66d9 into main Jan 17, 2023
@RobPasMue RobPasMue deleted the maint/migrate_ignore_words_to_vale branch January 17, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate ignore_words.txt to Vale reject.txt file

4 participants