Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Disallow value as string #232

Merged
merged 3 commits into from
Feb 14, 2024
Merged

refactor: Disallow value as string #232

merged 3 commits into from
Feb 14, 2024

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Feb 14, 2024

q = ansunits.Quantity("string", "m") was allowed.

image

@hpohekar hpohekar requested a review from a team as a code owner February 14, 2024 13:00
@hpohekar hpohekar linked an issue Feb 14, 2024 that may be closed by this pull request
@github-actions github-actions bot added the bug Something isn't working label Feb 14, 2024
@github-actions github-actions bot added the testing Anything related to tests label Feb 14, 2024
@hpohekar hpohekar requested a review from mkundu1 February 14, 2024 13:39
@hpohekar hpohekar merged commit 4c6413d into main Feb 14, 2024
26 checks passed
@hpohekar hpohekar deleted the fix/string_value_allowed branch February 14, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing Anything related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: String Allowed With NumPy Installed
3 participants