-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Configure angle as dimension #309
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be discussed and completely reworked.
@hpohekar Please could you create a separate pull request for the other changes? |
@seanpearsonuk Done. #313 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests look good so I will approve at this point, thanks.
We are going to add some more tests, then we will merge this PR. Thank you. |
closes #307,
ANGLE
andSOLID_ANGLE
as dimension using PYANSYS_UNITS_ANGLE_AS_DIMENSION env varDimensions without angle
------------------------------------------------------------------------------
Dimension with angle - set env var PYANSYS_UNITS_ANGLE_AS_DIMENSION