FEAT: add geometry-mechanical-dpf workflow #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobPasMue
reviewed
Jun 20, 2024
RobPasMue
reviewed
Jun 20, 2024
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
|
Can you try and replicate the existing CI/CD workflows? I will help you out as needed. |
RobPasMue
reviewed
Jun 20, 2024
dipinknair
force-pushed
the
feat/pymechanical
branch
from
5b396d3 to
2cfb942
Compare
dipinknair
force-pushed
the
feat/pymechanical
branch
2 times, most recently
from
9451bde to
bccbc3d
Compare
dipinknair
force-pushed
the
feat/pymechanical
branch
from
bccbc3d to
84c8286
Compare
MaxJPRey
reviewed
Jun 21, 2024
MaxJPRey
reviewed
Jun 21, 2024
MaxJPRey
reviewed
Jun 21, 2024
MaxJPRey
reviewed
Jun 21, 2024
MaxJPRey
reviewed
Jun 21, 2024
dipinknair
force-pushed
the
feat/pymechanical
branch
from
fbce572 to
2c4046c
Compare
Co-authored-by: Maxime Rey <87315832+MaxJPRey@users.noreply.github.com>
|
@dipinknair - next time, please do not ignore our suggestions. You resolved @MaxJPRey's comments without implementing the fixes. |
RobPasMue
approved these changes
Jun 24, 2024
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
|
@dipinknair - please add a description to the main README as well with this new workflow. Look at the existing ones for other workflows |
RobPasMue
reviewed
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To verify , download output folder from cicd and check if geometry (pcb.pmdb) mechanical files (pcb.mechdb) and images are present. For dpf workflow, the model information is printed in cicd.