Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to PyAnsys doc style action #1348

Merged
merged 4 commits into from
Jan 15, 2024
Merged

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Jan 15, 2024

Following constant errors of the latest doc style checks: https://github.com/ansys/pydpf-core/actions/runs/7519356240/job/20467795502#step:3:38

Also has to rename the docs folder as doc

Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi added the CI/CD Related to CI/CD label Jan 15, 2024
@PProfizi PProfizi self-assigned this Jan 15, 2024
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi PProfizi force-pushed the ci/use_pyansys_doc_style_action branch from 72a9269 to 08c8427 Compare January 15, 2024 08:58
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
@PProfizi
Copy link
Contributor Author

PProfizi commented Jan 15, 2024

Note: the failure of the Documentation Build job is due to another issue to resolve separately. This PR only concerns the Doc Check Style job

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well! Thanks @PProfizi

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00b168b) 86.29% compared to head (a21f5a2) 86.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1348      +/-   ##
==========================================
- Coverage   86.29%   86.19%   -0.10%     
==========================================
  Files          81       81              
  Lines        9309     9302       -7     
==========================================
- Hits         8033     8018      -15     
- Misses       1276     1284       +8     

@PProfizi PProfizi merged commit c459464 into master Jan 15, 2024
38 of 40 checks passed
@PProfizi PProfizi deleted the ci/use_pyansys_doc_style_action branch January 15, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants