Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose output type for a GenericDataContainer #1403

Merged
merged 6 commits into from
Feb 6, 2024

Conversation

cbellot000
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ea8fa3) 87.86% compared to head (6e7a8ce) 86.94%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1403      +/-   ##
==========================================
- Coverage   87.86%   86.94%   -0.92%     
==========================================
  Files          81       81              
  Lines        9532     9537       +5     
==========================================
- Hits         8375     8292      -83     
- Misses       1157     1245      +88     

Copy link
Collaborator

@anseramosfe anseramosfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Camille, could you briefly explain me this change?

@PProfizi PProfizi added the enhancement New feature or request label Feb 6, 2024
@PProfizi PProfizi changed the title gdc choose getoutput type Choose output type for a GenericDataContainer Feb 6, 2024
@cbellot000 cbellot000 merged commit 5f1c99f into master Feb 6, 2024
40 checks passed
@cbellot000 cbellot000 deleted the feat/gdc_getoutput_type branch February 6, 2024 14:13
@PProfizi
Copy link
Contributor

PProfizi commented Feb 6, 2024

Camille, could you briefly explain me this change?

@anseramosfe this allows to query data from a GenericDataContainer as a 'custom' type, for example here as a binary string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants