-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from 251 to 252 #1791
base: master
Are you sure you want to change the base?
Switch from 251 to 252 #1791
Conversation
@@ -147,11 +147,11 @@ jobs: | |||
DOCSTRING: false | |||
secrets: inherit | |||
|
|||
pydpf-post_251: | |||
name: "PyDPF-Post with 251" | |||
pydpf-post_252: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guptadivya1501 We will also need retrocompatibility tests with 251, just like for 242 below
@@ -76,7 +76,7 @@ jobs: | |||
tests: | |||
uses: ./.github/workflows/tests.yml | |||
with: | |||
ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }} | |||
ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '252' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@guptadivya1501 We will also need a retro_251 test just like for retro_241. We actually also need a retro_242 which we must have forgotten to set when switching to 251
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1791 +/- ##
==========================================
- Coverage 88.10% 86.97% -1.14%
==========================================
Files 83 83
Lines 9965 9951 -14
==========================================
- Hits 8780 8655 -125
- Misses 1185 1296 +111 |
retro_251: | ||
name: "retro 251" | ||
uses: ./.github/workflows/tests.yml | ||
with: | ||
ANSYS_VERSION: "251" | ||
python_versions: '["3.9"]' | ||
standalone_suffix: '.sp01' | ||
DOCSTRING: false | ||
secrets: inherit | ||
|
||
retro_242: | ||
name: "retro 242" | ||
uses: ./.github/workflows/tests.yml | ||
with: | ||
ANSYS_VERSION: "242" | ||
python_versions: '["3.9"]' | ||
standalone_suffix: '.sp01' | ||
DOCSTRING: false | ||
secrets: inherit | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
retro_251: | |
name: "retro 251" | |
uses: ./.github/workflows/tests.yml | |
with: | |
ANSYS_VERSION: "251" | |
python_versions: '["3.9"]' | |
standalone_suffix: '.sp01' | |
DOCSTRING: false | |
secrets: inherit | |
retro_242: | |
name: "retro 242" | |
uses: ./.github/workflows/tests.yml | |
with: | |
ANSYS_VERSION: "242" | |
python_versions: '["3.9"]' | |
standalone_suffix: '.sp01' | |
DOCSTRING: false | |
secrets: inherit | |
retro_251: | |
name: "retro 251" | |
uses: ./.github/workflows/tests.yml | |
with: | |
ANSYS_VERSION: "251" | |
python_versions: '["3.9"]' | |
DOCSTRING: false | |
secrets: inherit | |
retro_242: | |
name: "retro 242" | |
uses: ./.github/workflows/tests.yml | |
with: | |
ANSYS_VERSION: "242" | |
python_versions: '["3.9"]' | |
DOCSTRING: false | |
secrets: inherit | |
No description provided.