Switch from 251 to 252 #1791
Open
Switch from 251 to 252 #1791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PProfizi
reviewed
Oct 3, 2024
| @@ -147,11 +147,11 @@ jobs: | |||
| DOCSTRING: false | |||
| secrets: inherit | |||
|
|
|||
| pydpf-post_251: | |||
| name: "PyDPF-Post with 251" | |||
| pydpf-post_252: | |||
There was a problem hiding this comment.
@guptadivya1501 We will also need retrocompatibility tests with 251, just like for 242 below
PProfizi
reviewed
Oct 3, 2024
| @@ -76,7 +76,7 @@ jobs: | |||
| tests: | |||
| uses: ./.github/workflows/tests.yml | |||
| with: | |||
| ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '251' }} | |||
| ANSYS_VERSION: ${{ github.event.inputs.ansys_version || '252' }} | |||
There was a problem hiding this comment.
@guptadivya1501 We will also need a retro_251 test just like for retro_241. We actually also need a retro_242 which we must have forgotten to set when switching to 251
PProfizi
reviewed
Oct 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1791 +/- ##
==========================================
- Coverage 88.10% 86.97% -1.14%
==========================================
Files 83 83
Lines 9965 9951 -14
==========================================
- Hits 8780 8655 -125
- Misses 1185 1296 +111 |
PProfizi
reviewed
Oct 7, 2024
Comment on lines
+113
to
+132
| retro_251: | ||
| name: "retro 251" | ||
| uses: ./.github/workflows/tests.yml | ||
| with: | ||
| ANSYS_VERSION: "251" | ||
| python_versions: '["3.9"]' | ||
| standalone_suffix: '.sp01' | ||
| DOCSTRING: false | ||
| secrets: inherit | ||
|
|
||
| retro_242: | ||
| name: "retro 242" | ||
| uses: ./.github/workflows/tests.yml | ||
| with: | ||
| ANSYS_VERSION: "242" | ||
| python_versions: '["3.9"]' | ||
| standalone_suffix: '.sp01' | ||
| DOCSTRING: false | ||
| secrets: inherit | ||
|
|
There was a problem hiding this comment.
Suggested change
| retro_251: | |
| name: "retro 251" | |
| uses: ./.github/workflows/tests.yml | |
| with: | |
| ANSYS_VERSION: "251" | |
| python_versions: '["3.9"]' | |
| standalone_suffix: '.sp01' | |
| DOCSTRING: false | |
| secrets: inherit | |
| retro_242: | |
| name: "retro 242" | |
| uses: ./.github/workflows/tests.yml | |
| with: | |
| ANSYS_VERSION: "242" | |
| python_versions: '["3.9"]' | |
| standalone_suffix: '.sp01' | |
| DOCSTRING: false | |
| secrets: inherit | |
| retro_251: | |
| name: "retro 251" | |
| uses: ./.github/workflows/tests.yml | |
| with: | |
| ANSYS_VERSION: "251" | |
| python_versions: '["3.9"]' | |
| DOCSTRING: false | |
| secrets: inherit | |
| retro_242: | |
| name: "retro 242" | |
| uses: ./.github/workflows/tests.yml | |
| with: | |
| ANSYS_VERSION: "242" | |
| python_versions: '["3.9"]' | |
| DOCSTRING: false | |
| secrets: inherit | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.