Fix hidden operators exposure #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
…e.operators.build.build_operators() Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
…build_operators() Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1821 +/- ##
=======================================
Coverage 88.10% 88.10%
=======================================
Files 83 83
Lines 9951 9951
=======================================
Hits 8767 8767
Misses 1184 1184 |
Signed-off-by: paul.profizi <paul.profizi@ansys.com>
… deprecation Signed-off-by: paul.profizi <paul.profizi@ansys.com>
PProfizi
commented
Oct 24, 2024
| hidden = 0 | ||
| # List of hidden operators to still expose for retro-compatibility | ||
| # until they are fully deprecated | ||
| hidden_to_expose = [ # Use internal names |
There was a problem hiding this comment.
@cbellot000 here is the list of exceptions for hidden operators to still expose as Python modules
cbellot000
approved these changes
Oct 24, 2024
| with open(init_file_path, "w") as init_file: | ||
| init_file.writelines(sorted(lines)) | ||
| core.set_default_server_context(core.AvailableServerContexts.premium) | ||
| core.start_local_server(config=core.AvailableServerConfigs.LegacyGrpcServer) |
There was a problem hiding this comment.
@cbellot000 that is historical but we could try with the GrpcServer. In a next PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes a PR on the server-side to hide hidden operators.
It also refactors Python operator code generation for simplification and improved maintainability.