PyPIM integration #237
Merged
PyPIM integration #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anslpa
reviewed
May 13, 2022
cbellot000
approved these changes
May 16, 2022
anslpa
approved these changes
May 17, 2022
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 85.41% 85.45% +0.03%
==========================================
Files 52 52
Lines 5624 5650 +26
==========================================
+ Hits 4804 4828 +24
- Misses 820 822 +2 |
|
@plule-ansys Maybe a small test to pass the brand new codecov criteria? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates PyPIM. In an environment configured for PIM, DpfServer is now able to start a remote instance of DPF and connect to it.
The integration approach is intended to follow the current pydpf direction and does not add any gRPC specific dependency. PyPIM itself being based on gRPC, it is lazy loaded under the condition that the user is starting dpf in a pypim environment. It however changes the construction of the channel from "ip/port" to any address as supported by gRPC: https://grpc.github.io/grpc/core/md_doc_naming.html
It currently comes with a limitation that the headers are not transmitted to the instances. It means that this implementation will not work if the DPF instance is behind a gateway, or in an authenticated environment.