feat: give a default name to loaded plugins #2661
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r os management for the path, and an updated docstring
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2661 +/- ##
===========================================
- Coverage 84.26% 45.88% -38.38%
===========================================
Files 92 92
Lines 10858 10863 +5
===========================================
- Hits 9149 4985 -4164
- Misses 1709 5878 +4169 |
rafacanton
reviewed
Oct 8, 2025
PProfizi
commented
Oct 8, 2025
|
Some tests with 'continue-on-error: true' have failed:
Created by continue-on-error-comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default name given to plugins loaded using
load_libraryis an empty string and not aNone, which creates a name conflict if two plugins are loaded without explicit names.This PR adds a default name to plugins loaded with no
nameargument.