Merge/0.5.dev2 code fixes to remove warnings #311
Conversation
| @@ -37,59 +24,6 @@ def module_exists(module_name): | |||
| return module_name in (name for loader, name, ispkg in iter_modules()) | |||
|
|
|||
|
|
|||
| class Report(ScoobyReport): | |||
There was a problem hiding this comment.
@cbellot000 Why remove scooby exactly? It should be replaced with the pyansys reporting tool. It was not a priority due to Scooby already being there but I guess now it is something to remember to add.
There was a problem hiding this comment.
@PProfizi scooby was holding a reference on some of our object (in my case the issue was with a global variable named CLIENT_CONFIGURATION which is a DataTree, the reference on it prevented it from being properly destructed)
There was a problem hiding this comment.
@PProfizi do you think this report was used anywhere?
There was a problem hiding this comment.
@cbellot000 oh okay, then I guess it is okay. We needed to change to the pyansys report tool anyway.
ansys/dpf/core/data_tree.py
Outdated
| @@ -43,9 +44,9 @@ class DataTree: | |||
|
|
|||
| >>> from ansys.dpf import core as dpf | |||
| >>> data_tree = dpf.DataTree({"num_entities":3, "list_of_raws":[1,2,3,4], "name": "George"}) | |||
| >>> data_tree.get_as("name", dpf.types.string) | |||
| >>> data_tree.get_as("name",dpf.types.string) | |||
There was a problem hiding this comment.
@cbellot000 I sphinx saying we should remove those spaces? I think what we end with is not PEP, we might actually want to look into the sphinx config.
cbellot000
changed the title
No description provided.