Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/doc building #472

Closed
wants to merge 83 commits into from
Closed

Fix/doc building #472

wants to merge 83 commits into from

Conversation

PProfizi
Copy link
Contributor

@PProfizi PProfizi commented Sep 8, 2022

Solves #428

The Documentation check passes but the documentation artifact is actually empty (easily verified with its small size of 48 kB, should be more than 100MB).
The last known Documentation generation job to work was here on August 22.
Was rerun to check for unseen change in a dependency, it still passed.

Seems to have started with bump of Graphviz to 0.20.1 here. Cannot find an occurrence before that.

Two problems here:

the documentation check did not see something was wrong with the doc (artifact too small / step too short)
no error was raised although something went obviously wrong

@PProfizi PProfizi added the documentation Improvements or additions to documentation label Sep 8, 2022
@PProfizi PProfizi self-assigned this Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #472 (81f2599) into master (c592c22) will decrease coverage by 7.48%.
The diff coverage is n/a.

❗ Current head 81f2599 differs from pull request most recent head 21a2bcc. Consider uploading reports for the commit 21a2bcc to get more accurate results

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   86.48%   78.99%   -7.49%     
==========================================
  Files          65       65              
  Lines        6963     6961       -2     
==========================================
- Hits         6022     5499     -523     
- Misses        941     1462     +521     

@PProfizi PProfizi added CI/CD Related to CI/CD and removed documentation Improvements or additions to documentation labels Sep 8, 2022
@github-actions github-actions bot added the bug Something isn't working label Sep 8, 2022
@PProfizi PProfizi marked this pull request as draft September 12, 2022 13:33
@PProfizi
Copy link
Contributor Author

Solved in #472

@PProfizi PProfizi closed this Sep 13, 2022
@PProfizi PProfizi deleted the fix/doc_building branch November 28, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI/CD Related to CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant