Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FieldsContainer.animate for specific cases. #570

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Conversation

PProfizi
Copy link
Contributor

Fix the animation of a multi-component field without a "deform_by" argument.
Raise an error if fields_container obtained from the evaluation of a result or operator "deform_by" argument is not of the same length as the FieldsContainer being animated.
Improve example.

@PProfizi PProfizi added the bug Something isn't working label Oct 18, 2022
@PProfizi PProfizi added this to the v0.6.1 milestone Oct 18, 2022
@PProfizi PProfizi self-assigned this Oct 18, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #570 (4033543) into master (46c9892) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #570      +/-   ##
==========================================
+ Coverage   86.84%   86.98%   +0.13%     
==========================================
  Files          67       67              
  Lines        7221     7220       -1     
==========================================
+ Hits         6271     6280       +9     
+ Misses        950      940      -10     

Copy link
Contributor

@cbellot000 cbellot000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understood correctly the test_animator have no assert ? They only check that it didn't throw?

@PProfizi
Copy link
Contributor Author

If I understood correctly the test_animator have no assert ? They only check that it didn't throw?

Some basic ones do when checking simple things, but otherwise no, as animating a FieldsContainer does not return anything, except for a potential GIF.

@PProfizi PProfizi merged commit 4f29392 into master Oct 19, 2022
@PProfizi PProfizi deleted the fix/animations branch October 19, 2022 09:17
PProfizi added a commit that referenced this pull request Oct 19, 2022
…ss field with no deform_by argument. (#570)

(cherry picked from commit 4f29392)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants