Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Doc/several operators page #646

Merged
merged 24 commits into from
Nov 30, 2022

Conversation

anslpa
Copy link
Contributor

@anslpa anslpa commented Nov 25, 2022

  • finish taking comments into account
  • update htmls
  • remove pictures for Operators Entry and Premium cards

@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #646 (0d615e3) into master (bd4a811) will increase coverage by 0.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #646      +/-   ##
==========================================
+ Coverage   88.05%   88.23%   +0.18%     
==========================================
  Files          69       69              
  Lines        7750     7750              
==========================================
+ Hits         6824     6838      +14     
+ Misses        926      912      -14     

@PProfizi PProfizi added this to the v0.7.1 milestone Nov 25, 2022
@PProfizi PProfizi added the documentation Improvements or additions to documentation label Nov 25, 2022
@anslpa anslpa requested a review from PipKat November 28, 2022 15:24
@PipKat
Copy link
Member

PipKat commented Nov 28, 2022

@anslpa the dpf_entry.html and dpf_premium.html files are too large to edit here. Let me know if you want me to check out your branch and edit these files.

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
Copy link
Contributor

@cbellot000 cbellot000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a status on the premium/entry logos?

Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@anslpa
Copy link
Contributor Author

anslpa commented Nov 30, 2022

Do we have a status on the premium/entry logos?

We'll remove the logos and have a section explaining differences between entry and premium and explaining advanced premium capabilities (showing workflows ?).

@anslpa anslpa merged commit b58b329 into master Nov 30, 2022
@anslpa anslpa deleted the doc/several_operators_page_anslpa branch November 30, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants