fix unit tests for 2023.2.pre1 server and add License context manager #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
==========================================
- Coverage 88.89% 88.88% -0.02%
==========================================
Files 72 72
Lines 8193 8220 +27
==========================================
+ Hits 7283 7306 +23
- Misses 910 914 +4 |
cbellot000
changed the title
cbellot000
requested review from
jose-henriquezroa,
PProfizi,
JennaPaikowsky and
rlagha
src/ansys/dpf/core/server_context.py
Outdated
Comment on lines
44
to
48
| """Can be optionally used to pre checkout a licence before using licensed DPF Operators. | ||
| Improves performances if many Operators requiring licensing are used afterwards. | ||
| It can also be used to force checkout before running a script when few | ||
| ANSYS license increments are available. | ||
| Check in the license when the object is deleted. |
There was a problem hiding this comment.
For line 48, my assumption is that the check in is automatic when the object is deleted. If you have to manually check in the license after deleting the object, keep line 48 as originally written.
There was a problem hiding this comment.
that's correct @JennaPaikowsky, thanks
Co-authored-by: JennaPaikowsky <98607744+JennaPaikowsky@users.noreply.github.com>
…s/DPF-Core into feat/preprate_2023.2.pre1
PProfizi
reviewed
Mar 22, 2023
Comment on lines
+188
to
+189
| """Sets the default number of threads to use for all operators, | ||
| default is omp_get_num_threads. |
There was a problem hiding this comment.
Suggested change
| """Sets the default number of threads to use for all operators, | |
| default is omp_get_num_threads. | |
| """Returns the license timeout in seconds. |
PProfizi
reviewed
Mar 22, 2023
| return self._data_tree.get_as("license_timeout_in_seconds", types.double) | ||
|
|
||
| @license_timeout_in_seconds.setter | ||
| def license_timeout_in_seconds(self, value): |
There was a problem hiding this comment.
Suggested change
| def license_timeout_in_seconds(self, value): | |
| def license_timeout_in_seconds(self, value): | |
| """Sets the license timeout in seconds.""" |
PProfizi
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.