Skip to content

Conversation

Gobot1234
Copy link
Collaborator

Definitely needs testing cause it was a big find and replace job

Comment on lines 560 to 566
###############################################################################
# Confirm and update boundaries
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# Confirm and update the boundaries.

meshing_session.workflow.TaskObject["Update Boundaries"].Execute()

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
###############################################################################
# Confirm and update boundaries
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# Confirm and update the boundaries.
meshing_session.workflow.TaskObject["Update Boundaries"].Execute()

# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# Confirm and update the boundaries.

meshing_session.workflow.TaskObject["Update Boundaries"].Execute()
Copy link
Collaborator Author

@Gobot1234 Gobot1234 Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looked sus (moving the code around)

Suggested change
meshing_session.workflow.TaskObject["Update Boundaries"].Execute()
###############################################################################
# Confirm and update boundaries
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# Confirm and update the boundaries.
meshing_session.workflow.TaskObject["Update Boundaries"].Execute()


pyfluent.config.print_search_results = False
results = pyfluent.search("local*", api_path="<solver_session>.setup")
results = pyfluent.search("local*", api_path="<solver_session>.setup.")
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
results = pyfluent.search("local*", api_path="<solver_session>.setup.")
results = pyfluent.search("local*", api_path="<solver_session>.setup")

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 09:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes access to solver session settings throughout the test suite and examples. The changes update all references from direct access patterns (e.g., solver.setup.models) to the correct settings-based access pattern (e.g., solver.settings.setup.models). This is a comprehensive update ensuring consistent API usage across the entire codebase.

  • Updates solver session settings access pattern in tests and examples
  • Adds missing .settings prefix to all solver session attribute access
  • Minor formatting improvements and code cleanup

Reviewed Changes

Copilot reviewed 69 out of 70 changed files in this pull request and generated 6 comments.

File Description
tests/*.py Updated solver session settings access to use .settings prefix
examples/*.py Updated solver session settings access pattern in all examples
src/ansys/fluent/core/*.py Updated settings access in core modules
doc/source/*.rst Updated documentation examples to use correct settings API

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 16:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 68 out of 69 changed files in this pull request and generated 6 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Copilot Copilot AI review requested due to automatic review settings October 10, 2025 09:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 68 out of 69 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants