-
Notifications
You must be signed in to change notification settings - Fork 57
fix: solver session settings access in tests and examples #4512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
############################################################################### | ||
# Confirm and update boundaries | ||
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
# Confirm and update the boundaries. | ||
|
||
meshing_session.workflow.TaskObject["Update Boundaries"].Execute() | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
############################################################################### | |
# Confirm and update boundaries | |
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
# Confirm and update the boundaries. | |
meshing_session.workflow.TaskObject["Update Boundaries"].Execute() |
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
# Confirm and update the boundaries. | ||
|
||
meshing_session.workflow.TaskObject["Update Boundaries"].Execute() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looked sus (moving the code around)
meshing_session.workflow.TaskObject["Update Boundaries"].Execute() | |
############################################################################### | |
# Confirm and update boundaries | |
# ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | |
# Confirm and update the boundaries. | |
meshing_session.workflow.TaskObject["Update Boundaries"].Execute() |
tests/test_search.py
Outdated
|
||
pyfluent.config.print_search_results = False | ||
results = pyfluent.search("local*", api_path="<solver_session>.setup") | ||
results = pyfluent.search("local*", api_path="<solver_session>.setup.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
results = pyfluent.search("local*", api_path="<solver_session>.setup.") | |
results = pyfluent.search("local*", api_path="<solver_session>.setup") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
161dd03
to
376508f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes access to solver session settings throughout the test suite and examples. The changes update all references from direct access patterns (e.g., solver.setup.models
) to the correct settings-based access pattern (e.g., solver.settings.setup.models
). This is a comprehensive update ensuring consistent API usage across the entire codebase.
- Updates solver session settings access pattern in tests and examples
- Adds missing
.settings
prefix to all solver session attribute access - Minor formatting improvements and code cleanup
Reviewed Changes
Copilot reviewed 69 out of 70 changed files in this pull request and generated 6 comments.
File | Description |
---|---|
tests/*.py | Updated solver session settings access to use .settings prefix |
examples/*.py | Updated solver session settings access pattern in all examples |
src/ansys/fluent/core/*.py | Updated settings access in core modules |
doc/source/*.rst | Updated documentation examples to use correct settings API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 68 out of 69 changed files in this pull request and generated 6 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 68 out of 69 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Definitely needs testing cause it was a big find and replace job