fix: Update exception type for scheme call #4518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpohekar
requested review from
mkundu1,
seanpearsonuk,
prmukherj and
mayankansys
as code owners
2 tasks
mkundu1
approved these changes
Oct 7, 2025
prmukherj
reviewed
Oct 7, 2025
prmukherj
approved these changes
Oct 7, 2025
There was a problem hiding this comment.
Pull Request Overview
Updates the exception handling in get_cortex_connection_properties to align with the new GrpcErrorInterceptor behavior by catching RuntimeError instead of the previous gRPC-specific _InactiveRpcError, and adds a corresponding changelog entry.
- Replace specific gRPC exception catch with RuntimeError
- Remove now-unused local import of _InactiveRpcError
- Add changelog fragment documenting the change
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ansys/fluent/core/fluent_connection.py | Broadened caught exception type from _InactiveRpcError to RuntimeError and removed the related local import. |
| doc/changelog.d/4518.fixed.md | Added changelog fragment describing the exception handling update. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
seanpearsonuk
approved these changes
Oct 8, 2025
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes the exception type caught in the get_cortex_connection_properties method of fluent_connection.py. Previously the code only caught grpc._channel._InactiveRpcError — but with the introduction of the GrpcErrorInterceptor, failures may now propagate as RuntimeError.
With this PR:
The except _InactiveRpcError: branch is replaced by except RuntimeError: to correctly intercept failures from the new interceptor path.
Logging and fallback behavior remain unchanged.
A changelog fragment has been added (in doc/changelog.d/4518.fixed.md) to capture this change for release notes.
Motivation & Context
This change is necessary because errors previously not being caught would bubble up and potentially break upstream logic. Ensuring the correct exception is caught maintains expected behavior and stability, especially when using the newer gRPC error interceptor mechanism.
Impact
There should be no user‑facing API change; behavior when connections fail is preserved.