feat: avoiding reconnecting if MAPDL exited already #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3708 +/- ##
==========================================
+ Coverage 87.88% 88.07% +0.18%
==========================================
Files 187 187
Lines 14710 14703 -7
==========================================
+ Hits 12928 12949 +21
+ Misses 1782 1754 -28 |
|
@pyansys-ci-bot LGTM. |
…cting-if-MAPDL-exited-already
germa89
deleted the
feat/avoiding-reconnecting-if-MAPDL-exited-already
branch
germa89
added a commit
that referenced
this pull request
Feb 14, 2025
* test: refactor check_stds and post_mortem_checks * test: backing off algorithm * chore: adding changelog file 3703.added.md [dependabot-skip] * fix: codacity warnings * feat: using get_value to obtain the n elements * revert: revert "feat: using get_value to obtain the n elements" Performance is not as go This reverts commit 877f803. * feat: using get_value to obtain the n elements * revert: revert "feat: using get_value to obtain the n elements" Performance is not as go This reverts commit 877f803. * feat: using mapdl.exit when raising final error. * test: fix test by avoiding killing mapdl. * fix: test * fix: test * feat: adding warnings when restarting MAPDL during testing * fix: test * feat: caching requires_package * test: adding more tests * chore: adding changelog file 3705.added.md [dependabot-skip] * chore: adding changelog file 3705.added.md [dependabot-skip] * fix: warnings import * feat: not reconnecting if MAPDL already exited * test: adding tests * chore: adding changelog file 3708.miscellaneous.md [dependabot-skip] * fix: tests --------- Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title.
Issue linked
Close #3707
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)