fix: exiting on class deletion #3738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3738 +/- ##
==========================================
+ Coverage 88.07% 88.26% +0.19%
==========================================
Files 187 187
Lines 14717 14701 -16
==========================================
+ Hits 12962 12976 +14
+ Misses 1755 1725 -30 |
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
germa89
added a commit
that referenced
this pull request
Feb 14, 2025
* test: __del__method. * refactor: simplifying exit * chore: adding changelog file 3738.fixed.md [dependabot-skip] * refactor: simplyfing for other interfaces. * feat: exiting mapdl * feat: adding __del__ to mapdl_console * fix: improve job ID handling and remove atexit registration in MAPDL core --------- Co-authored-by: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Kills MAPDL on object deletion if the instance was launched by that instance.
Issue linked
Close #3692
Close #3394
Close #3514
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)